big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HDFS-6235. TestFileJournalManager can fail on Windows due to file locking if tests run out of order. Contributed by Chris Nauroth.

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1586692 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Chris Nauroth 2014-04-11 15:45:39 +00:00
parent 0a0ca4f062
commit 6d45bb54d2
2 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
View File

@ -378,6 +378,9 @@ Release 2.4.1 - UNRELEASED
HDFS-6234. TestDatanodeConfig#testMemlockLimit fails on Windows due to HDFS-6234. TestDatanodeConfig#testMemlockLimit fails on Windows due to
invalid file path. (cnauroth) invalid file path. (cnauroth)
HDFS-6235. TestFileJournalManager can fail on Windows due to file locking if
tests run out of order. (cnauroth)
Release 2.4.0 - 2014-04-07 Release 2.4.0 - 2014-04-07
INCOMPATIBLE CHANGES INCOMPATIBLE CHANGES

14
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileJournalManager.java
View File

@ -139,7 +139,7 @@ public void testNormalOperation() throws IOException {
*/ */
@Test @Test
public void testInprogressRecovery() throws IOException { public void testInprogressRecovery() throws IOException {
File f = new File(TestEditLog.TEST_DIR + "/filejournaltest0"); File f = new File(TestEditLog.TEST_DIR + "/inprogressrecovery");
// abort after the 5th roll // abort after the 5th roll
NNStorage storage = setupEdits(Collections.<URI>singletonList(f.toURI()), NNStorage storage = setupEdits(Collections.<URI>singletonList(f.toURI()),
5, new AbortSpec(5, 0)); 5, new AbortSpec(5, 0));
@ -255,7 +255,7 @@ public void testFinalizeErrorReportedToNNStorage() throws IOException, Interrupt
*/ */
@Test @Test
public void testReadFromStream() throws IOException { public void testReadFromStream() throws IOException {
File f = new File(TestEditLog.TEST_DIR + "/filejournaltest1"); File f = new File(TestEditLog.TEST_DIR + "/readfromstream");
// abort after 10th roll // abort after 10th roll
NNStorage storage = setupEdits(Collections.<URI>singletonList(f.toURI()), NNStorage storage = setupEdits(Collections.<URI>singletonList(f.toURI()),
10, new AbortSpec(10, 0)); 10, new AbortSpec(10, 0));
@ -282,7 +282,7 @@ public void testReadFromStream() throws IOException {
*/ */
@Test @Test
public void testAskForTransactionsMidfile() throws IOException { public void testAskForTransactionsMidfile() throws IOException {
File f = new File(TestEditLog.TEST_DIR + "/filejournaltest2"); File f = new File(TestEditLog.TEST_DIR + "/askfortransactionsmidfile");
NNStorage storage = setupEdits(Collections.<URI>singletonList(f.toURI()), NNStorage storage = setupEdits(Collections.<URI>singletonList(f.toURI()),
10); 10);
StorageDirectory sd = storage.dirIterator(NameNodeDirType.EDITS).next(); StorageDirectory sd = storage.dirIterator(NameNodeDirType.EDITS).next();
@ -307,7 +307,7 @@ public void testAskForTransactionsMidfile() throws IOException {
*/ */
@Test @Test
public void testManyLogsWithGaps() throws IOException { public void testManyLogsWithGaps() throws IOException {
File f = new File(TestEditLog.TEST_DIR + "/filejournaltest3"); File f = new File(TestEditLog.TEST_DIR + "/manylogswithgaps");
NNStorage storage = setupEdits(Collections.<URI>singletonList(f.toURI()), 10); NNStorage storage = setupEdits(Collections.<URI>singletonList(f.toURI()), 10);
StorageDirectory sd = storage.dirIterator(NameNodeDirType.EDITS).next(); StorageDirectory sd = storage.dirIterator(NameNodeDirType.EDITS).next();
@ -341,7 +341,7 @@ public boolean accept(File dir, String name) {
*/ */
@Test @Test
public void testManyLogsWithCorruptInprogress() throws IOException { public void testManyLogsWithCorruptInprogress() throws IOException {
File f = new File(TestEditLog.TEST_DIR + "/filejournaltest5"); File f = new File(TestEditLog.TEST_DIR + "/manylogswithcorruptinprogress");
NNStorage storage = setupEdits(Collections.<URI>singletonList(f.toURI()), 10, new AbortSpec(10, 0)); NNStorage storage = setupEdits(Collections.<URI>singletonList(f.toURI()), 10, new AbortSpec(10, 0));
StorageDirectory sd = storage.dirIterator(NameNodeDirType.EDITS).next(); StorageDirectory sd = storage.dirIterator(NameNodeDirType.EDITS).next();
@ -426,7 +426,7 @@ private static EditLogInputStream getJournalInputStream(JournalManager jm,
@Test @Test
public void testReadFromMiddleOfEditLog() throws CorruptionException, public void testReadFromMiddleOfEditLog() throws CorruptionException,
IOException { IOException {
File f = new File(TestEditLog.TEST_DIR + "/filejournaltest2"); File f = new File(TestEditLog.TEST_DIR + "/readfrommiddleofeditlog");
NNStorage storage = setupEdits(Collections.<URI>singletonList(f.toURI()), NNStorage storage = setupEdits(Collections.<URI>singletonList(f.toURI()),
10); 10);
StorageDirectory sd = storage.dirIterator(NameNodeDirType.EDITS).next(); StorageDirectory sd = storage.dirIterator(NameNodeDirType.EDITS).next();
@ -449,7 +449,7 @@ public void testReadFromMiddleOfEditLog() throws CorruptionException,
@Test @Test
public void testExcludeInProgressStreams() throws CorruptionException, public void testExcludeInProgressStreams() throws CorruptionException,
IOException { IOException {
File f = new File(TestEditLog.TEST_DIR + "/filejournaltest2"); File f = new File(TestEditLog.TEST_DIR + "/excludeinprogressstreams");
// Don't close the edit log once the files have been set up. // Don't close the edit log once the files have been set up.
NNStorage storage = setupEdits(Collections.<URI>singletonList(f.toURI()), NNStorage storage = setupEdits(Collections.<URI>singletonList(f.toURI()),