Commit Graph

664 Commits

Author SHA1 Message Date
Arun Suresh
6708ac3301 YARN-5587. Add support for resource profiles. (vvasudev via asuresh) 2017-09-12 09:19:10 -07:00
Varun Vasudev
c2032e251e YARN-5708. Implement APIs to get resource profiles from the RM. Contributed by Varun Vasudev. 2017-09-12 09:19:10 -07:00
Junping Du
3fddabc2fe YARN-7072. Add a new log aggregation file format controller. Contributed by Xuan Gong. 2017-09-08 15:16:19 -07:00
Haibo Chen
8edc60531f HADOOP-14847. Remove Guava Supplier and change to java Supplier in AMRMClient and AMRMClientAysnc. (Bharat Viswanadham via Haibo Chen) 2017-09-08 14:33:11 -07:00
Sunil G
56d93d2e39 YARN-6600. Introduce default and max lifetime of application at LeafQueue level. Contributed by Rohith Sharma K S. 2017-09-08 07:15:17 +05:30
Arun Suresh
c41118a7f8 YARN-6978. Add updateContainer API to NMClient. (Kartheek Muthyala via asuresh) 2017-09-07 10:23:12 -07:00
Jason Lowe
704267cb49 YARN-7164. TestAMRMClientOnRMRestart fails sporadically with bind address in use. Contributed by Jason Lowe 2017-09-06 15:23:49 -05:00
Junping Du
63231a2a30 YARN-7148. TestLogsCLI fails in trunk and branch-2 and javadoc error. Contributed by Xuan Gong. 2017-09-06 13:19:34 -07:00
Varun Saxena
ef87d34a0e YARN-7152. [ATSv2] Registering timeline client before AMRMClient service init throw exception (Rohith Sharma K S via Varun Saxena) 2017-09-04 20:11:02 +05:30
Andrew Wang
0d419c984f Preparing for 3.1.0 development 2017-09-01 11:53:48 -07:00
Junping Du
91cc070d67 YARN-6877. Create an abstract log reader for extendability. Contributed by Xuan Gong. 2017-08-31 16:41:43 -07:00
Robert Kanter
ce79f7be29 YARN-7094. Document the current known issue with server-side NM graceful decom (rkanter) 2017-08-30 18:04:55 -07:00
Jian He
08f40bcc7f MAPREDUCE-6838. [ATSv2 Security] Add timeline delegation token received in allocate response to UGI. Contributed by Varun Saxena 2017-08-30 11:29:54 +05:30
Rohith Sharma K S
7594d1de7b YARN-6130. [ATSv2 Security] Generate a delegation token for AM when app collector is created and pass it to AM via NM and RM. Contributed by Varun Saxena. 2017-08-30 11:29:53 +05:30
Jian He
8201ed8009 YARN-6756. ContainerRequest#executionTypeRequest causes NPE. Contributed by Jian He 2017-08-29 20:35:53 -07:00
Wangda Tan
51881a863c YARN-7112. TestAMRMProxy is failing with invalid request. (Jason Lowe via wangda)
Change-Id: I432f4523921666ac218fcf9936f826a0d8d635e0
2017-08-28 11:37:35 -07:00
Junping Du
c2cb7ea1ef YARN-6876. Create an abstract log writer for extendability. Contributed by Xuan Gong. 2017-08-24 13:36:49 -07:00
Jason Lowe
14553061be YARN-7020. TestAMRMProxy#testAMRMProxyTokenRenewal is flakey. Contributed by Robert Kanter 2017-08-16 13:04:36 -05:00
Arun Suresh
4d7be1d857 YARN-5978. ContainerScheduler and ContainerManager changes to support ExecType update. (Kartheek Muthyala via asuresh) 2017-08-14 19:46:17 -07:00
Arun Suresh
8d3fd81980 YARN-6920. Fix resource leak that happens during container re-initialization. (asuresh) 2017-08-07 18:59:25 -07:00
Arun Suresh
35dc782923 YARN-5977. ContainerManagementProtocol changes to support change of container ExecutionType. (Kartheek Muthyala via asuresh) 2017-08-03 21:15:40 -07:00
Yufei Gu
c617fe02b3 YARN-6832. Tests use assertTrue(....equals(...)) instead of assertEquals()). (Daniel Templeton via Yufei Gu) 2017-08-03 11:33:37 -07:00
Subru Krishnan
98b45b0ed3 YARN-6093. Minor bugs with AMRMtoken renewal and state store availability when using FederationRMFailoverProxyProvider during RM failover. (Botong Huang via Subru).
(cherry picked from commit 66500f4fa6155d29435d7c92fd6d68079c4cab86)
2017-08-01 17:28:22 -07:00
Jian He
bdfad4523f YARN-3673. Create a FailoverProxy for Federation services. Contributed by Subru Krishnan
(cherry picked from commit 3307564a5f8c8abc5fe84efcd05ee0f7dfdd921c)
2017-08-01 17:28:20 -07:00
Daniel Templeton
4c40cd451c YARN-6844. AMRMClientImpl.checkNodeLabelExpression() has wrong error message
(Contributed by Manikandan R via Daniel Templeton)
2017-07-24 12:03:02 -07:00
Andrew Wang
af2773f609 Updating version for 3.0.0-beta1 development 2017-06-29 17:57:40 -07:00
Daniel Templeton
036a24bab3 MAPREDUCE-6896. Document wrong spelling in usage of MapredTestDriver tools.
(Contributed by LiXin Ge via Daniel Templeton)
2017-06-13 13:21:23 -07:00
Brahma Reddy Battula
19ef3a81f8 HADOOP-14485. Redundant 'final' modifier in try-with-resources statement. Contributed by wenxin he. 2017-06-06 23:11:47 +08:00
Andrew Wang
16ad896d5c Update maven version for 3.0.0-alpha4 development 2017-05-26 14:09:44 -07:00
Daniel Templeton
d81372dfad YARN-6646. Modifier 'static' is redundant for inner enums
(Contributed by ZhangBing Lin via Daniel Templeton)
2017-05-26 12:05:48 -07:00
Jian He
8236130b2c YARN-6306. NMClient API change for container upgrade. Contributed by Arun Suresh 2017-05-16 10:48:46 -07:00
Jason Lowe
6099deebcb YARN-6552. Increase YARN test timeouts from 1 second to 10 seconds. Contributed by Eric Badger 2017-05-10 08:47:48 -05:00
Karthik Kambatla
166be0ee95 YARN-3742. YARN RM will shut down if ZKClient creation times out. (Daniel Templeton via kasha) 2017-05-09 14:44:16 -07:00
Naganarasimha
64f68cb0b8 YARN-6520. Fix warnings from Spotbugs in hadoop-yarn-client. Contributed by Weiwei Yang. 2017-05-01 18:38:22 +05:30
Eric Payne
fdf5192bbb YARN-6536. TestAMRMClient.testAMRMClientWithSaslEncryption fails intermittently. Contributed by Jason Lowe. 2017-04-28 15:20:35 -05:00
Akira Ajisaka
8a99eba96d
Revert "YARN-5007. Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster. Contributed by Andras Bokor."
This reverts commit 34ab8e73d4.
2017-04-26 15:34:23 +09:00
Sunil G
9ff25408bc YARN-6164. Expose Queue Configurations per Node Label through YARN client api. Contributed by Benson Qiu. 2017-04-19 20:39:09 +05:30
Jason Lowe
90d97372ed YARN-6461. TestRMAdminCLI has very low test timeouts. Contributed by Eric Badger 2017-04-11 09:16:11 -05:00
Jason Lowe
1b081ca27e YARN-6288. Exceptions during aggregated log writes are mishandled. Contributed by Akira Ajisaka 2017-04-06 16:24:36 -05:00
Akira Ajisaka
34ab8e73d4
YARN-5007. Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster. Contributed by Andras Bokor. 2017-04-05 17:33:07 +09:00
Jason Lowe
4d1fac5df2 YARN-6411. Clean up the overwrite of createDispatcher() in subclass of MockRM. Contributed by Yufei Gu 2017-03-31 10:05:34 -05:00
Daniel Templeton
33815af424 YARN-6334. TestRMFailover#testAutomaticFailover always passes even when it should fail
(Contributed by Yufei Gu via Daniel Templeton)
2017-03-24 11:42:54 -07:00
Junping Du
c01d15ab27 YARN-6367. YARN logs CLI needs alway check containerLogsInfo/containerLogInfo before parse the JSON object from NMWebService. Contributed by Xuan Gong. 2017-03-21 10:53:27 -07:00
Junping Du
871dc420f8 YARN-6313. YARN logs cli should provide logs for a completed container even when application is still running. Contributed by Xuan Gong.
(cherry picked from commit b88f5e0f7858d1d89b79dfd325b767c34416052d)
2017-03-14 12:58:12 -07:00
Jian He
4478273e5f HADOOP-14062. ApplicationMasterProtocolPBClientImpl.allocate fails with EOFException when RPC privacy is enabled. Contributed by Steven Rand 2017-03-10 09:25:58 -08:00
Jian He
2be8947d12 Revert "HADOOP-14062. ApplicationMasterProtocolPBClientImpl.allocate fails with EOFException when RPC privacy is enabled. Contributed by Steven Rand"
This reverts commit 241c1cc05b.
2017-03-08 13:20:01 -08:00
Jian He
241c1cc05b HADOOP-14062. ApplicationMasterProtocolPBClientImpl.allocate fails with EOFException when RPC privacy is enabled. Contributed by Steven Rand 2017-03-08 10:48:27 -08:00
Ray Chiang
2148b83993 YARN-6218. Fix TestAMRMClient when using FairScheduler. (Miklos Szegedi via rchiang) 2017-03-03 13:04:51 -08:00
Wangda Tan
1a6ca75f38 YARN-6143. Fix incompatible issue caused by YARN-3583. (Sunil G via wangda) 2017-02-22 11:17:09 -08:00
Li Lu
5d339c46f5 YARN-6177. Yarn client should exit with an informative error message if an incompatible Jersey library is used at client. Contributed by Weiwei Yang. 2017-02-16 13:41:42 -08:00
Sangjin Lee
4fa1afdb88 YARN-4675. Reorganize TimelineClient and TimelineClientImpl into separate classes for ATSv1.x and ATSv2. Contributed by Naganarasimha G R. 2017-02-16 11:41:04 -08:00
Karthik Kambatla
652679aa8a YARN-6061. Add an UncaughtExceptionHandler for critical threads in RM. (Yufei Gu via kasha) 2017-02-14 13:39:41 -08:00
Arun Suresh
aaf106fde3 YARN-5966. AMRMClient changes to support ExecutionType update. (asuresh) 2017-02-14 06:09:10 -08:00
Daniel Templeton
1238fa71f8 YARN-6166. Unnecessary INFO logs in AMRMClientAsyncImpl$CallbackHandlerThread.run (Contributed by Grant Whiteheart via Daniel Templeton) 2017-02-10 09:46:11 -08:00
Jason Lowe
37b4acf7ce YARN-6137. Yarn client implicitly invoke ATS client which accesses HDFS. Contributed by Li Lu 2017-02-08 14:59:09 -06:00
Junping Du
327c9980aa YARN-6100. Improve YARN webservice to output aggregated container logs. Contributed by Xuan Gong. 2017-02-02 00:41:18 -08:00
Junping Du
1a16431bd0 YARN-6126. Obtaining app logs for Running application fails with json parse error. Contributed by Xuan Gong. 2017-01-27 06:31:10 -08:00
Sangjin Lee
425a7e5028 YARN-3637. Handle localization sym-linking correctly at the YARN level. Contributed by Chris Trezzo. 2017-01-25 15:51:36 -08:00
Junping Du
8528d85a68 YARN-6099. Improve webservice to list aggregated log files. Contributed by Xuan Gong. 2017-01-24 15:26:53 -08:00
Andrew Wang
5d8b80ea9b Preparing for 3.0.0-alpha3 development 2017-01-19 15:50:07 -08:00
Subru Krishnan
4d1f3d9020 YARN-6016. Fix minor bugs in handling of local AMRMToken in AMRMProxy. (Botong Huang via Subru). 2017-01-17 14:48:03 -08:00
Akira Ajisaka
e407449ddb HADOOP-13933. Add haadmin -getAllServiceState option to get the HA state of all the NameNodes/ResourceManagers. Contributed by Surendra Singh Lilhore. 2017-01-17 10:10:23 +09:00
Junping Du
4db119b7b5 YARN-6079. Fix simple spelling errors in yarn test code. Contributed by vijay. 2017-01-10 18:20:27 -08:00
Daniel Templeton
6332a318bc YARN-6073. Misuse of format specifier in Preconditions.checkArgument (Contributed by Yuanbo Liu via Daniel Templeton) 2017-01-09 22:12:58 -08:00
Wangda Tan
0a55bd841e YARN-5959. RM changes to support change of container ExecutionType. (Arun Suresh via wangda) 2017-01-05 10:31:05 -08:00
Rohith Sharma K S
e297be74ed YARN-6001. Improve moveApplicationQueues command line. Contributed by Sunil G. 2016-12-28 12:16:11 +05:30
Robert Kanter
9262797e86 YARN-5257. Fix unreleased resources and null dereferences (yufeigu via rkanter) 2016-12-27 14:14:08 -08:00
Varun Saxena
38e66d4d64 YARN-5903. Fix race condition in TestResourceManagerAdministrationProtocolPBClientImpl beforeclass setup method (Haibo Chen via Varun Saxena) 2016-12-22 23:08:33 +05:30
Akira Ajisaka
ae401539ea YARN-4994. Use MiniYARNCluster with try-with-resources in tests. Contributed by Andras Bokor. 2016-12-22 14:32:24 +09:00
Naganarasimha
358341398a YARN-5524. Yarn live log aggregation does not throw if command line arg is wrong. Contributed by Xuan Gong. 2016-12-20 06:36:25 +05:30
Arun Suresh
2273a74c1f YARN-5646. Add documentation and update config parameter names for scheduling of OPPORTUNISTIC containers. (Konstantinos Karanasos via asuresh) 2016-12-16 08:14:34 -08:00
Xuan
64a2d5be91 YARN-5999. AMRMClientAsync will stop if any exceptions thrown on allocate call. Contributed by Jian He 2016-12-14 14:33:23 -08:00
Robert Kanter
72fe546841 YARN-5963. Spelling errors in logging and exceptions for node manager, client, web-proxy, common, and app history code (gsohn via rkanter) 2016-12-07 15:07:25 -08:00
Sunil
ab923a53fc YARN-5965. Retrospect ApplicationReport#getApplicationTimeouts. Contributed by Rohith Sharma K S 2016-12-08 00:27:25 +05:30
Jian He
43ebff2e35 YARN-5559. Analyse 2.8.0/3.0.0 jdiff reports and fix any issues. Contributed by Akira Ajisaka & Wangda Tan 2016-12-05 11:39:34 -08:00
Daniel Templeton
2d77dc727d YARN-5901. Fix race condition in TestGetGroups beforeclass setup() (Contributed by Haibo Chen via Daniel Templeton) 2016-12-01 15:57:39 -08:00
Akira Ajisaka
209e805430 HADOOP-13506. Redundant groupid warning in child projects. Contributed by Kai Sasaki. 2016-11-28 14:34:57 +09:00
Sunil
eb0a483ed0 YARN-4206. Add Application timeouts in Application report and CLI. Contributed by Rohith Sharma K S. 2016-11-24 18:18:42 +05:30
Wei-Chiu Chuang
09520cb439 YARN-5271. ATS client doesn't work with Jersey 2 on the classpath. Contributed by Weiwei Yang. 2016-11-17 22:17:23 -06:00
Rohith Sharma K S
ce2847e794 YARN-5870. Expose getApplications API in YarnClient with GetApplicationsRequest parameter. Contributed by Jian He. 2016-11-17 08:48:35 +05:30
Varun Saxena
6a11877ab5 YARN-5891. yarn rmadmin -help contains a misspelled ResourceManager (Grant Sohn via Varun Saxena) 2016-11-17 03:26:13 +05:30
Arun Suresh
3219b7b4ac YARN-4597. Introduce ContainerScheduler and a SCHEDULED state to NodeManager container lifecycle. (asuresh) 2016-11-15 07:56:25 -08:00
Wangda Tan
ede1a473f5 YARN-5552. Add Builder methods for common yarn API records. (Tao Jie via wangda) 2016-11-11 13:34:56 -08:00
Eric Payne
93eeb13164 YARN-4218. Metric for resource*time that was preempted. Contributed by Chang Li. 2016-11-10 22:35:12 +00:00
Arun Suresh
283fa33feb YARN-5823. Update NMTokens in case of requests with only opportunistic containers. (Konstantinos Karanasos via asuresh) 2016-11-09 00:11:25 -08:00
Andrew Wang
e1c6ef2efa HADOOP-13789. Hadoop Common includes generated test protos in both jar and test-jar. Contributed by Sean Busbey. 2016-11-08 16:33:55 -08:00
Naganarasimha
aacf214a27 YARN-5697. Use CliParser to parse options in RMAdminCLI. Contributed by Tao jie 2016-11-02 04:44:33 +05:30
Robert Kanter
5877f20f9c HADOOP-10075. Update jetty dependency to version 9 (rkanter) 2016-10-27 16:09:00 -07:00
Robert Kanter
44fdf00964 YARN-5753. fix NPE in AMRMClientImpl.getMatchingRequests() (haibochen via rkanter) 2016-10-25 23:59:39 -07:00
Akira Ajisaka
d3bb69a667 YARN-5575. Many classes use bare yarn. properties instead of the defined constants. Contributed by Daniel Templeton. 2016-10-26 15:32:07 +09:00
Subru Krishnan
0a166b1347 YARN-5711. Propogate exceptions back to client when using hedging RM failover provider. 2016-10-24 18:59:51 -07:00
Naganarasimha
6e130c308c YARN-4855. Should check if node exists when replace nodelabels. Contributeed by Tao Jie 2016-10-03 02:02:26 -04:00
Robert Kanter
2549ee9d4c YARN-5693. Reduce loglevel to Debug in ContainerManagementProtocolProxy and AMRMClientImpl (yufeigu via rkanter) 2016-09-30 13:30:55 -07:00
Arun Suresh
10be45986c YARN-5486. Update OpportunisticContainerAllocatorAMService::allocate method to handle OPPORTUNISTIC container requests. (Konstantinos Karanasos via asuresh) 2016-09-29 15:11:41 -07:00
Naganarasimha
e4e72db5f9 YARN-3877. YarnClientImpl.submitApplication swallows exceptions. Contributed by Varun Saxena 2016-09-25 17:36:30 +05:30
Kihwal Lee
6e849cb658 YARN-5622. TestYarnCLI.testGetContainers fails due to mismatched date formats. Contributed by Eric Badger. 2016-09-23 14:09:25 -05:00
Naganarasimha
d0372dc613 YARN-3692. Allow REST API to set a user generated message when killing an application. Contributed by Rohith Sharma K S 2016-09-23 06:30:49 +05:30
Naganarasimha
ade7c2bc9c YARN-4232. TopCLI console support for HA mode. Contributed by Bibin A Chundatt 2016-09-17 09:52:39 +05:30
Rohith Sharma K S
729de3e6b6 YARN-5631. Missing refreshClusterMaxPriority usage in rmadmin help message. Contributed by Kai Sasaki. 2016-09-13 15:23:24 +05:30
Rohith Sharma K S
f9557127b3 YARN-5608. TestAMRMClient.setup() fails with ArrayOutOfBoundsException. Contributed by Daniel Templeton. 2016-09-06 14:09:45 +05:30
Arun Suresh
d6d9cff21b YARN-5221. Expose UpdateResourceRequest API to allow AM to request for change in container properties. (asuresh) 2016-08-30 15:52:29 -07:00
Zhe Zhang
ed6ff5cd78 YARN-5550. TestYarnCLI#testGetContainers should format according to CONTAINER_PATTERN. Contributed by Jonathan Hung. 2016-08-29 14:46:00 -07:00
Jason Lowe
4cbe61407d YARN-5560. Clean up bad exception catching practices in TestYarnClient. Contributed by Sean Po 2016-08-29 16:14:55 +00:00
Wangda Tan
19c743c1bb YARN-4889. Changes in AMRMClient for identifying resource-requests explicitly. (Arun Suresh via wangda) 2016-08-26 17:14:12 -07:00
Jason Lowe
3d86110a5c YARN-5389. TestYarnClient#testReservationDelete fails. Contributed by Sean Po 2016-08-25 14:42:06 +00:00
Varun Saxena
79603f5882 YARN-5537. Fix intermittent failure of TestAMRMClient#testAMRMClientWithContainerResourceChange (Bibin A Chundatt via Varun Saxena) 2016-08-25 14:10:34 +05:30
Naganarasimha
143c59e4c5 YARN-4491. yarn list command to support filtering by tags. Contributed by Varun Saxena 2016-08-24 01:53:02 +05:30
Junping Du
0da69c324d YARN-4676. Automatic and Asynchronous Decommissioning Nodes Status Tracking. Contributed by Diniel Zhi.
(cherry picked from commit d464483bf7f0b3e3be3ba32cd6c3eee546747ab5)

Conflicts:

	hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceTrackerService.java
	hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNode.java
	hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
2016-08-18 07:27:23 -07:00
Varun Saxena
e3037c5641 YARN-5523. Yarn running container log fetching causes OutOfMemoryError (Xuan Gong via Varun Saxena) 2016-08-18 01:45:33 +05:30
Rohith Sharma K S
666ad0b67b YARN-2398. TestResourceTrackerOnHA crashes. Contributed by Ajith S. 2016-08-11 11:27:00 +05:30
Rohith Sharma K S
3cd386bd97 YARN-5474. Typo mistake in AMRMClient#getRegisteredTimeineClient API. Contributed by Naganarasimha G R. 2016-08-09 22:28:54 +05:30
Arun Suresh
82c9e06101 YARN-5457. Refactor DistributedScheduling framework to pull out common functionality. (asuresh) 2016-08-09 00:42:29 -07:00
Vinod Kumar Vavilapalli (I am also known as @tshooter.)
83a2ffec40 YARN-5470. Addedum to differentiate exactly matching of log-files with regex in yarn log CLI. Contributed by Xuan Gong. 2016-08-08 14:28:07 -07:00
Junping Du
e605d47df0 YARN-5470. Differentiate exactly match with regex in yarn log CLI. Contributed by Xuan Gong. 2016-08-05 10:55:29 -07:00
Junping Du
3818393297 YARN-5226. Remove AHS enable check from LogsCLI#fetchAMContainerLogs. Contributed by Xuan Gong. 2016-08-02 10:41:46 -07:00
Arun Suresh
e5766b1dbe YARN-5113. Refactoring and other clean-up for distributed scheduling. (Konstantinos Karanasos via asuresh) 2016-07-31 11:48:25 -07:00
Junping Du
95f2b98597 YARN-5434. Add -client|server argument for graceful decommmission. Contributed by Robert Kanter. 2016-07-29 10:26:11 -07:00
Li Lu
26de4f0de7 YARN-5440. Use AHSClient in YarnClient when TimelineServer is running. (Xuan Gong via gtcarrera9) 2016-07-28 10:23:18 -07:00
Arun Suresh
2d8d183b19 YARN-5351. ResourceRequest should take ExecutionType into account during comparison. (Konstantinos Karanasos via asuresh) 2016-07-26 19:08:30 -07:00
Rohith Sharma K S
be34b2a8fd YARN-1126. Add validation of users input nodes-states options to nodes CLI. Contributed by Wei Yan. 2016-07-21 12:20:47 +05:30
Junping Du
dc2f4b6ac8 YARN-5213. Fix a bug in LogCLIHelpers which cause TestLogsCLI#testFetchApplictionLogs fails intermittently. Contributed by Xuan Gong. 2016-07-19 07:17:58 -07:00
Andrew Wang
da456ffd62 Preparing for 3.0.0-alpha2 development 2016-07-15 19:04:17 -07:00
Junping Du
7e5355c14e YARN-5339. Passing file to -out for YARN log CLI doesnt give warning or error code. Contributed by Xuan Gong. 2016-07-15 09:23:11 -07:00
Xuan
429347289c YARN-5363. For AM containers, or for containers of running-apps, "yarn logs" incorrectly only (tries to) shows syslog file-type by default. (Contributed by Vinod Kumar Vavilapalli) 2016-07-14 10:20:08 -07:00
Vinod Kumar Vavilapalli
d18050522c YARN-5339. Fixed "yarn logs" to fail when a file is passed to -out option instead of a directory. Contributed by Xuan Gong. 2016-07-13 14:52:30 -07:00
Vinod Kumar Vavilapalli
eb47163234 YARN-5200. Enhanced "yarn logs" to be able to get a list of containers whose logs are aggregated via a "show_container_log_info" option. Contributed by Xuan Gong. 2016-07-13 10:54:15 -07:00
Junping Du
7705812c7e New addendum to YARN-5080. Cannot obtain logs using YARN CLI -am for either KILLED or RUNNING AM. 2016-07-12 08:29:49 -07:00
Jian He
819224dcf9 YARN-5270. Solve miscellaneous issues caused by YARN-4844. Contributed by Wangda Tan 2016-07-11 22:36:20 -07:00
Sangjin Lee
6cf6ab7b78 Made a number of miscellaneous fixes for javac, javadoc, and checstyle warnings. 2016-07-10 08:46:05 -07:00
Sangjin Lee
0d02ab8729 YARN-3367. Replace starting a separate thread for post entity with event loop in TimelineClient (Naganarasimha G R via sjlee) 2016-07-10 08:45:53 -07:00
Junping Du
2188a07e5b YARN-3333. Rename TimelineAggregator etc. to TimelineCollector. Contributed by Sangjin Lee 2016-07-10 08:45:31 -07:00
Zhijie Shen
9b56364080 YARN-3039. Implemented the app-level timeline aggregator discovery service. Contributed by Junping Du. 2016-07-10 08:45:31 -07:00
Vinod Kumar Vavilapalli
4c9e1aeb94 YARN-5224. Added new web-services /containers/{containerid}/logs & /containers/{containerid}/logs/{filename} and using them in "yarn logs" CLI to get logs of finished containers of a running application. Contributed by Xuan Gong. 2016-07-06 14:10:54 -07:00
Jian He
d169f5052f YARN-5227. Yarn logs command: no need to specify applicationId when
specifying containerId. Contributed by Gergely Novák
2016-07-06 10:43:27 -07:00
Xuan
6ab5aa1c1f YARN-5266. Wrong exit code while trying to get app logs using regex via CLI. Contributed by Xuan Gong 2016-06-22 21:48:49 -07:00
Arun Suresh
99e5dd68d0 YARN-5171. Extend DistributedSchedulerProtocol to notify RM of containers allocated by the Node. (Inigo Goiri via asuresh) 2016-06-22 19:04:54 -07:00
Tsuyoshi Ozawa
5d58858bb6 HADOOP-9613. [JDK8] Update jersey version to latest 1.x release. 2016-06-21 08:05:32 +09:00
Junping Du
c35fa4a0e5 YARN-5251. Yarn CLI to obtain App logs for last 'n' bytes fails. Contributed by Xuan Gong. 2016-06-17 08:24:24 -07:00
Junping Du
e14ee0d3b5 YARN-5083. YARN CLI for AM logs does not give any error message if entered invalid am value. Contributed by Jian He. 2016-06-16 08:55:56 -07:00
Varun Vasudev
25064fb2fb YARN-5223. Container line in yarn logs output for a live application should include the hostname for the container. Contributed by Xuan Gong. 2016-06-15 12:42:44 +05:30
Varun Vasudev
d6284428e8 YARN-5122. "yarn logs" for running containers should print an explicit footer saying that the log may be incomplete. Contributed by Jian He. 2016-06-15 12:35:17 +05:30
Wangda Tan
c77a1095dc YARN-1942. Deprecate toString/fromString methods from ConverterUtils and move them to records classes like ContainerId/ApplicationId, etc. (wangda) 2016-06-14 15:06:38 -07:00
Arun Suresh
5143277958 YARN-5124. Modify AMRMClient to set the ExecutionType in the ResourceRequest. (asuresh) 2016-06-12 09:42:38 -07:00
Wangda Tan
03fc6b1bb0 YARN-3426. Add jdiff support to YARN. (vinodkv via wangda) 2016-06-10 09:51:09 -07:00
Wangda Tan
244506f9c8 YARN-5208. Run TestAMRMClient TestNMClient TestYarnClient TestClientRMTokens TestAMAuthorization tests with hadoop.security.token.service.use_ip enabled. (Rohith Sharma K S via wangda) 2016-06-10 09:34:32 -07:00
Vinod Kumar Vavilapalli
5a43583c0b YARN-5080. Addendum fix to the original patch to fix YARN logs CLI. Contributed by Xuan Gong 2016-06-08 09:49:55 -07:00
Ming Ma
4a1cedc010 MAPREDUCE-5044. Have AM trigger jstack on task attempts that timeout before killing them. (Eric Payne and Gera Shegalov via mingma) 2016-06-06 14:30:51 -07:00
Arun Suresh
dc26601d8f YARN-5180. Allow ResourceRequest to specify an enforceExecutionType flag. (asuresh) 2016-06-02 09:01:02 -07:00
Xuan
0bc05e40fa YARN-5088. Improve "yarn log" command-line to read the last K bytes for the log files. Contributed by Xuan Gong 2016-06-01 13:44:21 -07:00
Varun Vasudev
4e1f56e111 YARN-5141. Get Container logs for the Running application from Yarn Logs CommandLine. Contributed by Xuan Gong. 2016-05-29 21:53:43 +05:30
Varun Vasudev
42f90ab885 YARN-4844. Add getMemorySize/getVirtualCoresSize to o.a.h.y.api.records.Resource. Contributed by Wangda Tan. 2016-05-29 21:24:16 +05:30
Akira Ajisaka
e4022debf7 YARN-5166. javadoc:javadoc goal fails on hadoop-yarn-client. Contributed by Andras Bokor. 2016-05-27 23:15:32 +09:00
Xuan
bde819abbb YARN-5089. Improve "yarn log" command-line "logFiles" option to support
regex. Contributed by Xuan Gong
2016-05-26 23:49:20 -07:00
Carlo Curino
013532a95e YARN-4957. Add getNewReservation in ApplicationClientProtocol (Sean Po via curino) 2016-05-25 16:55:49 -07:00
Naganarasimha
f04c81c9ce YARN-4925. ContainerRequest in AMRMClient, application should be able to specify nodes/racks together with nodeLabelExpression. Contributed by Bibin A Chundatt 2016-05-19 01:30:48 +08:00
Varun Vasudev
ef1757790d YARN-4913. Yarn logs should take a -out option to write to a directory. Contributed by Xuan Gong. 2016-05-18 22:44:33 +05:30
Arun Suresh
8a9ecb7584 YARN-5090. Add End-to-End test-cases for DistributedScheduling using MiniYarnCluster. (asuresh) 2016-05-17 19:01:29 -07:00
Xuan
7be53b65f9 YARN-5080. Cannot obtain logs using YARN CLI -am for either KILLED or
RUNNING AM. Contributed by Xuan Gong
2016-05-14 12:19:23 -07:00
Andrew Wang
3c5c57af28 HADOOP-13142. Change project version from 3.0.0 to 3.0.0-alpha1. 2016-05-12 18:27:28 -07:00
Andrew Wang
ca5613af91 Revert "Update project version to 3.0.0-alpha1-SNAPSHOT."
This reverts commit 6b53802cba.
2016-05-12 15:32:45 -07:00
Andrew Wang
6b53802cba Update project version to 3.0.0-alpha1-SNAPSHOT. 2016-05-12 11:05:05 -07:00
Vinod Kumar Vavilapalli
87f5e35133 YARN-4842. Fixed "yarn logs" command to guess (and thus not require) the appOwner argument when viewing another user's logs. Contributed by Ram Venkatesh and Xuan Gong. 2016-05-09 22:41:18 -07:00
Vinod Kumar Vavilapalli
9e37fe3b7a YARN-4905. Improved "yarn logs" command-line to optionally show log metadata also. Contributed by Xuan Gong. 2016-05-04 14:16:03 -07:00
Varun Vasudev
66b07d8374 YARN-4966. Improve yarn logs to fetch container logs without specifying nodeId. Contributed by Xuan Gong. 2016-04-27 15:56:36 +05:30
Arun Suresh
a5fed8bbfe YARN-4991. Fix ContainerRequest Constructor to set nodelabelExpression correctly. (Bibin A Chundatt via asuresh) 2016-04-25 23:26:21 -07:00
Arun Suresh
b2a654c5ee YARN-4335. Allow ResourceRequests to specify ExecutionType of a request ask (kkaranasos via asuresh)
(cherry picked from commit 8ffabfdf4fec104cdaa68133385cfe9cf88b95a8)
2016-04-22 23:20:54 -07:00
Karthik Kambatla
6e297836d6 YARN-4935. TestYarnClient#testSubmitIncorrectQueue fails when FairScheduler is the default. (Yufei Gu via kasha) 2016-04-20 23:40:46 -07:00
Rohith Sharma K S
ff722bbbdf YARN-4794. Deadlock in NMClientImpl. Contributed by Jian He. 2016-04-12 09:59:33 +05:30
Akira Ajisaka
1ff27f9d12 YARN-4630. Remove useless boxing/unboxing code. Contributed by Kousuke Saruta. 2016-04-11 14:55:03 +09:00
Jian He
8831b18c65 Missing file for YARN-4117. 2016-03-28 09:59:47 -07:00
Junping Du
19b645c938 YARN-4820. ResourceManager web redirects in HA mode drops query parameters. Contributed by Varun Vasudev. 2016-03-23 19:34:30 -07:00
Eric Payne
92b7e0d413 YARN-4686. MiniYARNCluster.start() returns before cluster is completely started. Contributed by Eric Badger. 2016-03-18 16:12:47 +00:00
Rohith Sharma K S
c1afac3a98 YARN-4654. Yarn node label CLI should parse "=" correctly when trying to remove all labels on a node. (Naganarasimha G R via rohithsharmaks) 2016-02-18 14:10:37 +05:30
Steve Loughran
51fc7f5427 YARN-4682. AMRM client to log when AMRM token updated. (Prabhu Joseph via stevel) 2016-02-12 11:02:08 +00:00
Varun Vasudev
2fb423e195 YARN-4684. TestYarnCLI#testGetContainers failing in CN locale. Contributed by Bibin A Chundatt. 2016-02-12 12:06:55 +05:30
Varun Vasudev
663a80031c YARN-4628. Display application priority in yarn top. Contributed by Bibin A Chundatt. 2016-02-11 11:56:09 +05:30
Steve Loughran
e9a622606f YARN-4629. Distributed shell breaks under strong security. (Daniel Templeton via stevel) 2016-02-10 13:01:10 +00:00
Wangda Tan
9875325d5c YARN-4340. Add list API to reservation system. (Sean Po via wangda) 2016-02-02 10:17:33 +08:00
Xuan
618bfd6ac2 YARN-4496. Improve HA ResourceManager Failover detection on the client.
Contributed by Jian He
2016-01-22 18:20:38 -08:00
Jason Lowe
e91e8b711c YARN-4371. "yarn application -kill" should take multiple application ids. Contributed by Sunil G 2016-01-22 21:36:15 +00:00
rohithsharmaks
34a3900773 YARN-4574. Fix random failure in TestAMRMClientOnRMRestart. (Takashi Ohnishi via rohithsharmaks) 2016-01-22 21:17:37 +05:30
Akira Ajisaka
8f58f742ae YARN-4605. Spelling mistake in the help message of "yarn applicationattempt" command. Contributed by Weiwei Yang. 2016-01-22 19:43:06 +09:00
Akira Ajisaka
62b0d61513 YARN-4534. Remove the redundant symbol in yarn rmadmin help msg. Contributed by Lin Yiqun. 2016-01-14 13:59:39 +09:00
Wangda Tan
8310b2e9ff YARN-4522. Queue acl can be checked at app submission. (Jian He via wangda) 2015-12-30 15:30:12 -08:00
Wangda Tan
a0de702851 YARN-4290. Add -showDetails option to YARN Nodes CLI to print all nodes reports information. (Sunil G via wangda) 2015-12-21 11:36:22 -08:00
Jian He
85c2466048 YARN-4164. Changed updateApplicationPriority API to return the updated application priority. Contributed by Rohith Sharma K S 2015-12-18 14:13:48 -08:00
Wangda Tan
7faa406f27 YARN-4225. Add preemption status to yarn queue -status for capacity scheduler. (Eric Payne via wangda) 2015-12-16 13:19:40 -08:00
Wangda Tan
79c41b1d83 YARN-4293. ResourceUtilization should be a part of yarn node CLI. (Sunil G via wangda) 2015-12-16 13:18:19 -08:00
Wangda Tan
23c625ec57 YARN-4384. updateNodeResource CLI should not accept negative values for resource. (Junping Du via wangda) 2015-11-24 16:35:56 -08:00
Wangda Tan
7ff280fca9 YARN-1509. Make AMRMClient support send increase container request and get increased/decreased containers. (Meng Ding via wangda) 2015-11-12 11:50:00 -08:00
Jason Lowe
06a70311b9 YARN-4345. yarn rmadmin -updateNodeResource doesn't work. Contributed by Junping Du 2015-11-12 14:49:06 +00:00
Wangda Tan
c99925d6dd YARN-1510. Make NMClient support change container resources. (Meng Ding via wangda) 2015-11-10 11:45:46 -08:00
Tsuyoshi Ozawa
9f4dfdf4eb YARN-4251. TestAMRMClientOnRMRestart#testAMRMClientOnAMRMTokenRollOverOnRMRestart is failing. Contributed by Brahma Reddy Battula. 2015-10-28 17:39:12 +09:00
Wangda Tan
3cc73773eb YARN-4285. Display resource usage as percentage of queue and cluster in the RM UI (Varun Vasudev via wangda) 2015-10-26 13:07:39 -07:00
Rohith Sharma K S
b57f08c0d2 YARN-4246. NPE while listing app attempt. (Nijel S F via rohithsharmaks) 2015-10-26 11:56:36 +05:30
Jason Lowe
a0bca2b5ad YARN-261. Ability to fail AM attempts. Contributed by Andrey Klochkov and Rohith Sharma K S 2015-10-09 14:17:38 +00:00
Xuan
8f08532bde YARN-1897. CLI and core support for signal container functionality. Contributed by Ming Ma 2015-10-02 18:50:47 -07:00
Jian He
89cab1ba5f YARN-1651. CapacityScheduler side changes to support container resize. Contributed by Wangda Tan 2015-09-23 13:29:38 -07:00
Jian He
c3dc1af072 YARN-1644. RM-NM protocol changes and NodeStatusUpdater implementation to support container resizing. Contributed by Meng Ding 2015-09-23 13:29:37 -07:00
Jason Lowe
692d51c09d YARN-3975. WebAppProxyServlet should not redirect to RM page if AHS is enabled. Contributed by Mit Desai 2015-09-23 16:38:55 +00:00
Tsuyoshi Ozawa
dfd807afab HADOOP-12428. Fix inconsistency between log-level guards and statements. Contributed by Jagadesh Kiran N and Jackie Chang. 2015-09-22 12:54:29 +09:00
Xuan
34ef1a092b YARN-4149. yarn logs -am should provide an option to fetch all the log
files. Contributed by Varun Vasudev
2015-09-15 14:36:30 -07:00
Wangda Tan
ae5308fe1d YARN-3717. Expose app/am/queue's node-label-expression to RM web UI / CLI / REST-API. (Naganarasimha G R via wangda) 2015-09-15 11:40:50 -07:00
Junping Du
73e3a49eb0 YARN-313. Add Admin API for supporting node resource configuration in command line. (Contributed by Inigo Goiri, Kenji Kikushima and Junping Du) 2015-09-15 07:56:47 -07:00
Robert Kanter
b84fb41bb6 YARN-4115. Reduce loglevel of ContainerManagementProtocolProxy to Debug (adhoot via rkanter) 2015-09-11 11:46:10 -07:00
Robert Kanter
6dd6ca442a YARN-4086. Allow Aggregated Log readers to handle HAR files (rkanter) 2015-09-09 18:03:04 -07:00
Varun Vasudev
b469ac531a YARN-3970. Add REST api support for Application Priority. Contributed by Naganarasimha G R. 2015-09-03 16:40:10 +05:30
Jian He
a3fd2ccc86 YARN-4092. Fixed UI redirection to print useful messages when both RMs are in standby mode. Contributed by Xuan Gong 2015-08-31 17:33:24 -07:00
Jian He
a9c8ea71aa YARN-3250. Support admin cli interface in for Application Priority. Contributed by Rohith Sharma K S 2015-08-27 13:25:53 -07:00
Jian He
57c7ae1aff YARN-4014. Support user cli interface in for Application Priority. Contributed by Rohith Sharma K S 2015-08-24 20:36:44 -07:00
Karthik Kambatla
13604bd5f1 YARN-4055. Report node resource utilization in heartbeat. (Inigo Goiri via kasha) 2015-08-16 15:08:53 -07:00
rohithsharmaks
1c12adb71f YARN-4023. Publish Application Priority to TimelineServer. (Sunil G via rohithsharmaks) 2015-08-12 14:45:41 +05:30
Rohith Sharma K S
b6265d39c5 YARN-3948. Display Application Priority in RM Web UI.(Sunil G via rohithsharmaks) 2015-08-07 10:43:41 +05:30
Arun Suresh
154c9d2e42 YARN-3961. Expose pending, running and reserved containers of a queue in REST api and yarn top (adhoot via asuresh) 2015-08-05 23:14:14 -07:00
Xuan
0306d902f5 YARN-3543. ApplicationReport should be able to tell whether the
Application is AM managed or not. Contributed by Rohith Sharma K S
2015-08-03 15:46:00 -07:00
Allen Wittenauer
da2d1ac4bc YARN-3915. scmadmin help message correction (Bibin A Chundatt via aw) 2015-07-21 09:44:45 -07:00
Akira Ajisaka
19295b36d9 YARN-3381. Fix typo InvalidStateTransitonException. Contributed by Brahma Reddy Battula. 2015-07-13 17:52:13 +09:00
Karthik Kambatla
527c40e4d6 YARN-1012. Report NM aggregated container resource utilization in heartbeat. (Inigo Goiri via kasha) 2015-07-09 09:35:14 -07:00
Junping Du
a95d39f9d0 YARN-3860. rmadmin -transitionToActive should check the state of non-target node. (Contributed by Masatake Iwasaki) 2015-06-28 22:26:47 -07:00
Xuan
5766a04428 YARN-3749. We should make a copy of configuration when init
MiniYARNCluster with multiple RMs. Contributed by Chun Chen
2015-06-03 17:20:15 -07:00
Zhijie Shen
bc85959edd Revert "YARN-1462. Made RM write application tags to timeline server and exposed them to users via generic history web UI and REST API. Contributed by Xuan Gong."
This reverts commit 4a9ec1a824.
2015-06-03 14:15:56 -07:00
Zhijie Shen
4a9ec1a824 YARN-1462. Made RM write application tags to timeline server and exposed them to users via generic history web UI and REST API. Contributed by Xuan Gong. 2015-05-30 21:05:36 -07:00
Wangda Tan
cab7674e54 YARN-3581. Deprecate -directlyAccessNodeLabelStore in RMAdminCLI. (Naganarasimha G R via wangda) 2015-05-27 15:34:38 -07:00
Devaraj K
0305316d69 YARN-3646. Applications are getting stuck some times in case of retry
policy forever. Contributed by Raju Bairishetti.
2015-05-21 20:14:44 +05:30
Wangda Tan
563eb1ad2a YARN-3583. Support of NodeLabel object instead of plain String in YarnClient side. (Sunil G via wangda) 2015-05-19 16:54:38 -07:00
Xuan
5009ad4a7f YARN-3601. Fix UT TestRMFailover.testRMWebAppRedirect. Contributed by Weiwei Yang 2015-05-19 09:56:01 -07:00
Xuan
b0ad644083 YARN-3526. ApplicationMaster tracking URL is incorrectly redirected on a QJM cluster. Contributed by Weiwei Yang 2015-05-15 22:39:49 -07:00
Devaraj K
241a72af0d YARN-2784. Make POM project names consistent. Contributed by Rohith. 2015-05-08 19:23:53 +05:30
Vinod Kumar Vavilapalli
f5fe35e297 YARN-3413. Changed Nodelabel attributes (like exclusivity) to be settable only via addToClusterNodeLabels but not changeable at runtime. (Wangda Tan via vinodkv) 2015-04-23 11:19:55 -07:00
Steve Loughran
d9bcf99aef YARN-2605. [RM HA] Rest api endpoints doing redirect incorrectly. (Xuan Gong via stevel) 2015-04-23 09:22:48 +01:00
Junping Du
fad9d7e85b New parameter of CLI for decommissioning node gracefully in RMAdmin CLI. Contributed by Devaraj K 2015-04-22 10:07:20 -07:00
Jian He
f967fd2f21 YARN-3497. ContainerManagementProtocolProxy modifies IPC timeout conf without making a copy. Contributed by Jason Lowe 2015-04-20 10:38:27 -07:00
Jian He
6779467ab6 YARN-3451. Display attempt start time and elapsed time on the web UI. Contributed by Rohith Sharmaks 2015-04-17 15:55:34 -07:00
Junping Du
1db355a875 YARN-1402. Update related Web UI and CLI with exposing client API to check log aggregation status. Contributed by Xuan Gong. 2015-04-17 13:18:59 -07:00
Junping Du
a77d628339 YARN-3347. Improve YARN log command to get AMContainer logs as well as running containers logs. Contributed by Xuan Gong. 2015-04-13 17:29:06 -07:00
Jian He
577d755e4b YARN-3348. Add a 'yarn top' tool to help understand cluster usage. Contributed by Varun Vasudev 2015-04-10 09:57:17 -07:00
Wangda Tan
2a945d24f7 YARN-2495. Allow admin specify labels from each NM (Distributed configuration for node label). (Naganarasimha G R via wangda) 2015-03-30 12:05:21 -07:00
Karthik Kambatla
c906a1de72 YARN-3397. yarn rmadmin should skip -failover. (J.Andreina via kasha) 2015-03-25 07:42:27 -07:00
Harsh J
fbceb3b418 YARN-1880. Cleanup TestApplicationClientProtocolOnHA. Contributed by ozawa. 2015-03-24 11:57:58 +05:30
Tsuyoshi Ozawa
3da9a97cfb YARN-1453. [JDK8] Fix Javadoc errors caused by incorrect or illegal tags in doc comments. Contributed by Akira AJISAKA, Andrew Purtell, and Allen Wittenauer. 2015-03-16 23:19:05 +09:00
Zhijie Shen
85f6d67fa7 YARN-1884. Added nodeHttpAddress into ContainerReport and fixed the link to NM web page. Contributed by Xuan Gong. 2015-03-11 19:35:19 -07:00
Vinod Kumar Vavilapalli
138c9cadee YARN-2786. Created a yarn cluster CLI and seeded with one command for listing node-labels collection. Contributed by Wangda Tan. 2015-03-05 10:54:34 -08:00
Jason Lowe
03cc22945e YARN-3131. YarnClientImpl should check FAILED and KILLED state in submitApplication. Contributed by Chang Li 2015-03-04 18:04:22 +00:00
Tsuyoshi Ozawa
d1c6accb6f HADOOP-11602. Fix toUpperCase/toLowerCase to use Locale.ENGLISH. (ozawa) 2015-03-03 14:17:52 +09:00
Tsuyoshi Ozawa
9cedad11d8 Revert "HADOOP-11602. Fix toUpperCase/toLowerCase to use Locale.ENGLISH. (ozawa)"
This reverts commit 946456c6d8.

Conflicts:
	hadoop-common-project/hadoop-common/CHANGES.txt
	hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/QuotaByStorageTypeEntry.java
2015-02-25 00:32:04 +09:00
Devaraj K
b610c68d44 YARN-2797. Add -help to yarn logs and nodes CLI command. Contributed by
Jagadesh Kiran N.
2015-02-24 12:04:06 +05:30
Wangda Tan
d49ae725d5 YARN-3076. Add API/Implementation to YarnClient to retrieve label-to-node mapping (Varun Saxena via wangda) 2015-02-19 11:00:57 -08:00
Tsuyoshi Ozawa
946456c6d8 HADOOP-11602. Fix toUpperCase/toLowerCase to use Locale.ENGLISH. (ozawa) 2015-02-19 13:06:53 +09:00
Xuan
253035491c YARN-3164. RMAdmin command usage prints incorrect command name.
Contributed by Bibin A Chundatt
2015-02-12 21:39:16 -08:00
Xuan
2586915bb3 YARN-3179. Update use of Iterator to Iterable in RMAdminCLI and
CommonNodeLabelsManager. Contributed by Ray Chiang
2015-02-12 17:31:45 -08:00